feat: support generate & format test files #112
Conversation
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
| // FIXME: | ||
| // _ => Err(ParseErrorKind::InvalidType(c)), |
There was a problem hiding this comment.
I haven't decided what's the final way yet. 🤪 How do you think?
There was a problem hiding this comment.
Let's discuss how to handle type-string here #36
sqllogictest/src/runner.rs
Outdated
| if let Some(hook) = &mut self.hook { | ||
| hook.on_stmt_complete(&sql).await; | ||
| } |
There was a problem hiding this comment.
Hook should be called after comparing the result.
Nevertheless, the hook feature can be removed now as we no longer use it. 🤪
There was a problem hiding this comment.
Hook should be called after comparing the result.
Why? Do you mean only run hooks if query/statement succeed?
the hook feature can be removed now as we no longer use it.
I'm not sure but it maybe useful sometimes #88 🤪
There was a problem hiding this comment.
only run hooks if query/statement succeed?
Previous implementation is indeed on_query_succeed_and_pass_test 🤪. Maybe we will also need others like on_query_succeed_and_fail_test... It's a little bit tricker than I thought.
Since no one is using it now, let's secretly remove it; Redesign and add back in future if needed. 😄
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
--override, and--formatRecordand parserIncluderecord when linking its contentHaltBegin/EndIncludetoInjectedHooksample run: risingwavelabs/risingwave#6776
close #43
close #90